Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SUP-43592): [PSU] Cue Points not showing in some YT Ingested Video Quiz #40

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Aug 25, 2024

Description of the Changes

Issue:
Markers are not shown on the player in youtube videos

Root cause:
When retrieving video duration via the YouTube Data API, the duration is returned as a rounded-up value. this value is used when creating the YouTube entry (from kms)
In the player, we use the getDuration() function from the YouTube iframe API, which returns the duration as a floating number.
In timeline manager we compare the duration: entry.duration === round(engine.duration) so in case of youtube entry with duration less then X.5 it will never be true

Fix:
If youtube entry is played, round up with ceil function

Resolved SUP-43592

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit 36f4ce4 into master Aug 29, 2024
4 checks passed
@Tzipi-kaltura Tzipi-kaltura deleted the SUP-43592 branch August 29, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants