fix(SUP-43592): [PSU] Cue Points not showing in some YT Ingested Video Quiz #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
Markers are not shown on the player in youtube videos
Root cause:
When retrieving video duration via the YouTube Data API, the duration is returned as a rounded-up value. this value is used when creating the YouTube entry (from kms)
In the player, we use the getDuration() function from the YouTube iframe API, which returns the duration as a floating number.
In timeline manager we compare the duration: entry.duration === round(engine.duration) so in case of youtube entry with duration less then X.5 it will never be true
Fix:
If youtube entry is played, round up with ceil function
Resolved SUP-43592
CheckLists