Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CR-152): add API for commit and restore cues #45

Merged
merged 7 commits into from
Dec 15, 2024
Merged

feat(CR-152): add API for commit and restore cues #45

merged 7 commits into from
Dec 15, 2024

Conversation

semarche-kaltura
Copy link
Contributor

@semarche-kaltura semarche-kaltura commented Dec 5, 2024 •
edited
Loading

Description of the Changes

  1. create timeline manager API (instead of share entire service)
  2. created API for dual-screen preview
  3. add remove all cues method into API
  4. chapters can have callback on header click

resolves: https://kaltura.atlassian.net/browse/CR-152

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@semarche-kaltura semarche-kaltura marked this pull request as ready for review December 5, 2024 23:13
SivanA-Kaltura
SivanA-Kaltura requested changes Dec 8, 2024
View reviewed changes
lianbenjamin
lianbenjamin previously approved these changes Dec 9, 2024
View reviewed changes
SivanA-Kaltura
SivanA-Kaltura previously approved these changes Dec 9, 2024
View reviewed changes
@MosheMaorKaltura MosheMaorKaltura merged commit 6484a85 into master Dec 15, 2024
4 checks passed
@MosheMaorKaltura MosheMaorKaltura deleted the CR-152-summary-cues branch December 15, 2024 09:13
@MosheMaorKaltura MosheMaorKaltura restored the CR-152-summary-cues branch December 15, 2024 10:42
MosheMaorKaltura added a commit that referenced this pull request Dec 15, 2024
@MosheMaorKaltura
Revert "feat(CR-152): add API for commit and restore cues (#45)"
a4e8f5e 
This reverts commit 6484a85.
@MosheMaorKaltura MosheMaorKaltura mentioned this pull request Dec 15, 2024
Merged
MosheMaorKaltura added a commit that referenced this pull request Dec 15, 2024
@MosheMaorKaltura
Revert "feat(CR-152): add API for commit and restore cues (#45)" (#46)
42fe274 
This reverts commit 6484a85.
MosheMaorKaltura added a commit that referenced this pull request Dec 15, 2024
@MosheMaorKaltura
Revert "Revert "feat(CR-152): add API for commit and restore cues (#45)…
66ad388 
…" (#46)"

This reverts commit 42fe274.
semarche-kaltura pushed a commit that referenced this pull request Dec 23, 2024
@MosheMaorKaltura
Revert "Revert "feat(CR-152): add API for commit and restore cues (#45)…
50081f9 
…" (#46)" (#47)

This reverts commit 42fe274.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@lianbenjamin lianbenjamin lianbenjamin left review comments

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@semarche-kaltura @lianbenjamin @SivanA-Kaltura @MosheMaorKaltura