Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-14300): gaps in the timeline progress #48

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

lianbenjamin
Copy link
Contributor

@lianbenjamin lianbenjamin commented Jan 2, 2025

Description of the Changes

bugfix - regression.

the issue:
when loading a video with chapters, there are gaps in the progress of the timeline.

root cause:
since changes in CR-152- the timeline manager is not registered as a service anymore, so reset() is not being invoked when changing media. As a result, when switching media there are duplicated chapters (and timeline segments).

solution:
add reset() to timelineManagerAPI service.

Solves FEC-14300

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@MosheMaorKaltura MosheMaorKaltura merged commit 77eb454 into master Jan 2, 2025
4 checks passed
@MosheMaorKaltura MosheMaorKaltura deleted the FEC-14300 branch January 2, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants