fix(FEC-14076): Player v7 | Download | Download notification popup is being display behind download overlay. #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
SivanA-Kaltura
requested review from
MosheMaorKaltura,
lianbenjamin,
semarche-kaltura and
JonathanTGold
lianbenjamin
approved these changes
Aug 1, 2024
JonathanTGold
suggested changes
Aug 1, 2024
| filter: blur($blur); | ||
| .player.overlay-active .interactive-area { | ||
| .filter { | ||
| filter: blur($blur); |
There was a problem hiding this comment.
this is the core component it should be agnostic and Un-Opinionated, style changes / customisation should be made locally for every plugin
JonathanTGold
suggested changes
Aug 1, 2024
| @@ -26,6 +26,7 @@ class InteractiveArea extends Component<any, any> { | |||
| const {children} = this.props; | |||
| return ( | |||
| <div className={style.interactiveArea}> | |||
| <div className={style.filter}></div> | |||
There was a problem hiding this comment.
core should not apply style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Move interactive area filter to a separate element
If interactive area itself has a filter, it affects every component within the interactive area, including popups, which should not be affected by it
Related PR: kaltura/playkit-js-ui-managers#61
Resolves FEC-14076
Issue:
Fix:
Resolves FEC-[Please add the ticket reference here]