Skip to content

Commit

Permalink
fix(FEX-14257): fix duplicating cues safari (#807)
Browse files Browse the repository at this point in the history
### Description of the Changes

Fix for https://kaltura.atlassian.net/browse/FEC-14257

### CheckLists

- [ ] changes have been done against master branch, and PR does not
conflict
- [ ] new unit / functional tests have been added (whenever applicable)
- [ ] test are passing in local environment
- [ ] Travis tests are passing (or test results are not worse than on
master branch :))
- [ ] Docs have been updated

---------

Co-authored-by: quantumInverter <[email protected]>
  • Loading branch information
DanilMolchanovKaltura and quantumInverter authored Jan 29, 2025
1 parent fb81ebd commit 035ee9e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/player.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1486,8 +1486,9 @@ export default class Player extends FakeEventTarget {
*/
private _applyTextTrackConfig(): void {
const textTrackDisplaySetting = Utils.Object.getPropertyPath(this._config, 'text.textTrackDisplaySetting');
const useNativeTextTrack = Utils.Object.getPropertyPath(this._config, 'text.useNativeTextTrack');
const textStyle = Utils.Object.getPropertyPath(this._config, 'text.textStyle');
if (textTrackDisplaySetting) {
if (textTrackDisplaySetting && !useNativeTextTrack) {
const textDisplaySettings: any = Utils.Object.mergeDeep({}, textTrackDisplaySetting, {
// align - backward compatibility || new caption alignment API || default value
align: textTrackDisplaySetting?.align || textStyle?.textAlign || 'center'
Expand Down

0 comments on commit 035ee9e

Please sign in to comment.