Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEX-14257): fix duplicating cues safari #807

Merged
merged 3 commits into from
Jan 29, 2025
Merged

fix(FEX-14257): fix duplicating cues safari #807

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6240f23
fix(FEC-14257): Fix duplicating captions on Safari
quantumInverter Jan 6, 2025
15a983b
fix(FEC-14257): Fix for duplicating captions
quantumInverter Jan 27, 2025
3fea42d
fix(FEC-14257): Fix for duplicating captions
quantumInverter Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,8 +1486,9 @@ export default class Player extends FakeEventTarget {
*/
private _applyTextTrackConfig(): void {
const textTrackDisplaySetting = Utils.Object.getPropertyPath(this._config, 'text.textTrackDisplaySetting');
const useNativeTextTrack = Utils.Object.getPropertyPath(this._config, 'text.useNativeTextTrack');
const textStyle = Utils.Object.getPropertyPath(this._config, 'text.textStyle');
if (textTrackDisplaySetting) {
if (textTrackDisplaySetting && !useNativeTextTrack) {
const textDisplaySettings: any = Utils.Object.mergeDeep({}, textTrackDisplaySetting, {
// align - backward compatibility || new caption alignment API || default value
align: textTrackDisplaySetting?.align || textStyle?.textAlign || 'center'
Expand Down
Loading