caching of small files in redis #13148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drorsou
reviewed
Feb 23, 2025
| try | ||
| { | ||
| $fileAdd = $redisWrapper->doSet($cacheKey, $contentToPut); | ||
| if ($fileAdd === false) |
There was a problem hiding this comment.
The wrapper doesn't seem to return NULL. Maybe just for in case, it should check if (!$fileAdd)
There was a problem hiding this comment.
when testing different redis images, when there was a problem i got an exception there.
i think just in case it better to have it
drorsou
reviewed
Feb 25, 2025
gonenradai
reviewed
Feb 25, 2025
yossipapi
reviewed
Feb 25, 2025
|
I didn’t review the entire code will do once your done but, where is the part that handles the fetching if these cached files when trying to get the file sync data? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.