Change CriticalityLevel to Dangerous when directive removed

kamilkisiela · Dec 1, 2024 · 7748677 · 7748677
1 parent ac6c9f9
commit 7748677
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/spotty-cats-drive.md b/.changeset/spotty-cats-drive.md
@@ -0,0 +1,5 @@
+---
+'@graphql-inspector/core': patch
+---
+
+Change CriticalityLevel to Dangerous when directive removed
diff --git a/packages/core/__tests__/diff/directive-usage.test.ts b/packages/core/__tests__/diff/directive-usage.test.ts
@@ -521,7 +521,7 @@ describe('directive-usage', () => {
       const change = findFirstChangeByPath(changes, 'Foo.external');
 
       expect(changes.length).toEqual(1);
-      expect(change.criticality.level).toEqual(CriticalityLevel.Breaking);
+      expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous);
       expect(change.type).toEqual('DIRECTIVE_USAGE_SCALAR_REMOVED');
       expect(change.message).toEqual("Directive 'external' was removed from scalar 'Foo'");
     });
@@ -612,7 +612,7 @@ describe('directive-usage', () => {
       const changes = await diff(a, b);
       const change = findFirstChangeByPath(changes, 'Foo.external');
 
-      expect(change.criticality.level).toEqual(CriticalityLevel.Breaking);
+      expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous);
       expect(change.type).toEqual('DIRECTIVE_USAGE_INTERFACE_REMOVED');
       expect(change.message).toEqual("Directive 'external' was removed from interface 'Foo'");
     });

diff --git a/packages/core/src/diff/changes/directive-usage.ts b/packages/core/src/diff/changes/directive-usage.ts
@@ -247,7 +247,7 @@ function buildDirectiveUsageInterfaceRemovedMessage(
 export function directiveUsageInterfaceRemovedFromMeta(args: DirectiveUsageInterfaceRemovedChange) {
   return {
     criticality: {
-      level: removedSpecialDirective(args.meta.removedDirectiveName, CriticalityLevel.Breaking),
+      level: removedSpecialDirective(args.meta.removedDirectiveName, CriticalityLevel.Dangerous),
       reason: `Directive '${args.meta.removedDirectiveName}' was removed from interface '${args.meta.interfaceName}'`,
     },
     type: ChangeType.DirectiveUsageInterfaceRemoved,
@@ -525,7 +525,7 @@ function buildDirectiveUsageScalarRemovedMessage(
 export function directiveUsageScalarRemovedFromMeta(args: DirectiveUsageScalarRemovedChange) {
   return {
     criticality: {
-      level: removedSpecialDirective(args.meta.removedDirectiveName, CriticalityLevel.Breaking),
+      level: removedSpecialDirective(args.meta.removedDirectiveName, CriticalityLevel.Dangerous),
       reason: `Directive '${args.meta.removedDirectiveName}' was removed from scalar '${args.meta.scalarName}'`,
     },
     type: ChangeType.DirectiveUsageScalarRemoved,