refactor!: fix namespaces, mark LamdaActivator internal but expose ct…

…or getters
kamranayub · Jun 13, 2024 · 180068d · 180068d
1 parent 55ad31e
commit 180068d
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/IGDB/IGDBApi.cs b/IGDB/IGDBApi.cs
@@ -3,6 +3,7 @@
 using System.IO;
 using System.Threading.Tasks;
 using IGDB.Models;
+using IGDB.Serialization;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Serialization;
 using RestEase;

diff --git a/IGDB/Serialization/IdentityConverter.cs b/IGDB/Serialization/IdentityConverter.cs
@@ -5,7 +5,7 @@
 using Newtonsoft.Json;
 using static IGDB.Serialization.LambdaActivator;
 
-namespace IGDB
+namespace IGDB.Serialization
 {
   public class IdentityConverter : JsonConverter
   {
@@ -137,7 +137,7 @@ private static ObjectActivator GetIdentitiesActivator(Type objectType)
       return activator;
     }
 
-    private static ObjectActivator GetValuesActivator(Type objectType)
+    public static ObjectActivator GetValuesActivator(Type objectType)
     {
       if (valuesActivators.ContainsKey(objectType))
       {
@@ -150,7 +150,7 @@ private static ObjectActivator GetValuesActivator(Type objectType)
       return activator;
     }
 
-    private static ObjectActivator GetIdentityActivator(Type objectType)
+    public static ObjectActivator GetIdentityActivator(Type objectType)
     {
       if (identityActivators.ContainsKey(objectType))
       {
@@ -163,7 +163,7 @@ private static ObjectActivator GetIdentityActivator(Type objectType)
       return activator;
     }
 
-    private static ObjectActivator GetValueActivator(Type objectType)
+    public static ObjectActivator GetValueActivator(Type objectType)
     {
       if (valueActivators.ContainsKey(objectType))
       {

diff --git a/IGDB/Serialization/LamdaActivator.cs b/IGDB/Serialization/LamdaActivator.cs
@@ -4,13 +4,13 @@
 
 namespace IGDB.Serialization
 {
+  public delegate object ObjectActivator(params object[] args);
+
   /// <summary>
   /// See: https://rogerjohansson.blog/2008/02/28/linq-expressions-creating-objects/
   /// </summary>
-  public static class LambdaActivator
+  internal static class LambdaActivator
   {
-    public delegate object ObjectActivator(params object[] args);
-
     public static ObjectActivator GetActivator(ConstructorInfo ctor)
     {
       ParameterInfo[] paramsInfo = ctor.GetParameters();

diff --git a/IGDB/Serialization/UnixTimestampConverter.cs b/IGDB/Serialization/UnixTimestampConverter.cs
@@ -2,7 +2,7 @@
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 
-namespace IGDB
+namespace IGDB.Serialization
 {
   public class UnixTimestampConverter : JsonConverter
   {