Auto icon changer #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a `\n` at the end of the `note` would, when the message gets truncated, separate the note itself and the 'Output too large. Godbolt link: ...' message. And, in the case the note would happen to be at the end of the message, Discord trims trailing newlines. I'm pretty sure this should work but haven't actually tested it. Signed-off-by: Astroide <[email protected]>
That encourages people to use the modmail command more often because it doesn't feel like snitching.
the PR includes the following changes: - adding MODMAIL_CHANNEL_ID to the template, because the bot doesn't start with that field abscent - removing the discriminator digits from the /ban command output, because they don't exist in discord anymore, so always defaulted to #0000 - a small refactor to the filtering of the /cleanup command, it just was in the area I was looking at, and I got confused by how it works - making all slash commands also accept ?, because that's what the help message says is supposed to happen. - fixing a bug where truncation will sometimes produce a message longer than 2000 characters, while also refactoring the function responsible for it --------- Co-authored-by: danielrab.work <[email protected]>
<!-- what develop branch? --> ball miri `unsafe` Signed-off-by: bendn <[email protected]>
Problem: when using `/selftimeout`, if you *only* specify the duration in hours, then an unexpected extra hour is added to the time. Result: pain and suffering. I have to wait an extra hour before ~~being offtopic in general~~ participating in productive conversations. Solution: match on the `hours` value when minutes isn't specified. If it's `0`, then the current default (60) is still used. If it's nonzero, use 0 instead.
Currently, Ferris attempts to edit the reply after the timeout of 600 seconds. However, if Ferris' response has been deleted, this will cause an Unknown Message error. To fix this, errors from editing the message will be ignored.
The missing code block error now uses code blocks to nicely format the error message: ## Old output  ## New output  Co-authored-by: Ivan Borgia Dardi <[email protected]>
If you forgot to give the bot access to the modmail channel you entered
in `Secrets.toml`, the error message wouldn't help you to figure out
what went wrong.
Previous error that was inscrutable:
> 024-01-09T14:32:02.131-05:00 [Runtime] WARN chaitrex_ferrisbot_test:
Encountered error: Setup { error: Missing Access
New error message:
> 2024-01-09T14:28:38.710-05:00 [Runtime] WARN chaitrex_ferrisbot_test:
Encountered error: Setup { error: Cannot enter modmail channel, …
Signed-off-by: Ivan Borgia Dardi <[email protected]>
Co-authored-by: Ivan Borgia Dardi <[email protected]>
i have made `maybe_wrap` work properly, instead of just doing string substitutions.  --------- Signed-off-by: Ivan Borgia Dardi <[email protected]> Co-authored-by: Ivan Borgia Dardi <[email protected]>
As recently discussed in #rustbot-development. Closes #26.
I did not test this locally. I attempted to revert it as cleanly as possible. If you prefer I can also revert the *entire* change which has a higher chance of being correct. fixes #29 --------- Co-authored-by: bendn <[email protected]>
|
omg I didn't mean to open a PR to the fork origin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.