Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20231115 updates #6

Merged
merged 24 commits into from
Nov 21, 2023
Merged

20231115 updates #6

merged 24 commits into from
Nov 21, 2023

Conversation

Firstyear
Copy link
Member

This is a pretty large rewrite of the whole library to allow new types of verifiers and signers to be added, such as hsm-crypto.

  • [ x ] cargo fmt has been run
  • [ x ] cargo test has been run and passes
  • [ x ] documentation has been updated with relevant examples (if relevant)

@Firstyear Firstyear requested a review from yaleman November 18, 2023 08:38
yaleman
yaleman approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@yaleman yaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor logging tweak suggestions but otherwise LGTM

src/compact.rs Outdated Show resolved Hide resolved
src/compact.rs Outdated Show resolved Hide resolved
src/compact.rs Outdated Show resolved Hide resolved
@Firstyear
Copy link
Member Author

Gonna tweak a trait first.

@Firstyear Firstyear merged commit b8669e3 into main Nov 21, 2023
1 check passed
@Firstyear Firstyear deleted the 20231115-updates branch November 21, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaleman yaleman yaleman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Firstyear @yaleman