Fix python error when printing a file that doesn't use the heated bed #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...on a printer that does have a heated bed. The error happens because `plugins.smartpreheat.bed` ends up being `None`, which can't be multiplied by a float. I'm not sure if this is new with Python 3. I decided to skip the smart preheat bed commands altogether if no bed temperature is found in the file (rather than just adding `or 0` to the preheat commands), as this is what the printed file would have done without smart preheat.
|
Should fix #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...on a printer that does have a heated bed.
The error happens because
plugins.smartpreheat.bedends up beingNone, which can't be multiplied by a float. I'm not sure if this is new with Python 3.I decided to skip the smart preheat bed commands altogether if no bed temperature is found in the file (rather than just adding
or 0to the preheat commands), as this is what the printed file would have done without smart preheat.