Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to limit maximum commits used for frecency #756

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

last-partizan
Copy link
Contributor

This adds an option to limit number of processed commits for frecency.

We use number instead of date, because it works the same for both active and not very active repos.

Refs #711

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (587938a) to head (43ccb45).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   89.86%   89.91%   +0.04%     
==========================================
  Files          19       19              
  Lines        1125     1130       +5     
==========================================
+ Hits         1011     1016       +5     
  Misses        114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

seagoat/repository.py Outdated Show resolved Hide resolved
Copy link
Owner

@kantord kantord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls just add some unit tests (I guess a test case for "infinte" mode, a test case for a custom limit and a test case for the default limit) and I will approve it

@last-partizan
Copy link
Contributor Author

Done, please take a look!

@kantord kantord merged commit 44bd95e into kantord:main Nov 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants