Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for deferred props #12

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

chuck-waters
Copy link
Contributor

This works in tandem with inertiajs/inertia#1617. This is the server-side implementation of having props that defer loading. They behave the same as lazy props, except on load. This allows properties to be loaded automatically after page loads/navigation.

Basically just a port of the PR inertiajs/inertia-laravel#531 from @adrum

Copy link
Owner

@kapi2289 kapi2289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@kapi2289 kapi2289 merged commit e49634d into kapi2289:main Apr 7, 2024
1 check passed
@NejcBW
Copy link

NejcBW commented Apr 25, 2024

This PR was merged but I don't think Inertia itself supports that unless I overlooked something. The referenced PR in Inertia's repo inertiajs/inertia#1617 has never been merged.

@kapi2289
Copy link
Owner

Hi @NejcBW. Yes, I didn't see it wasn't merged, by mistake. However, I won't release it in a new version until it's merged. I'll move this to a different branch, and revert it on the main for now. Thanks for the comment, and sorry for the inconvenience.

@chuck-waters
Copy link
Contributor Author

There is a fork of the Inertia project that does implement it. I think it would be very useful, hopefully people can upvote the PR over there to get it moving. It’s been up for 8 months

@NejcBW
Copy link

NejcBW commented May 1, 2024

@chuck-waters you mean Hybridly?

@chuck-waters
Copy link
Contributor Author

@chuck-waters you mean Hybridly?

Yep.

chuck-waters added a commit to chuck-waters/InertiaCore that referenced this pull request May 10, 2024
Add ability for deferred props  (kapi2289#12)
kapi2289 added a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants