Simplify populating each target's classes list in ReclassInventory
#1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to reconstruct the list of classes for each target. Reclass provides this information in `rendered_target["classes"]` already. This commit removes the loop which reconstructs the list and replaces it by assigning `rendered_target["classes"]` to the target's `classes` field. Side-note: the previous implementation also mangled the list, because Python implements `+=` for lists as list concatenation, and (not so helpfully) treats strings as lists of characters when they appear in a context where a list is expected. To correctly construct the list of classes with the previous approach, the `+=` should be replaced with append: ```python self.targets[target_name].classes.append(class_name) ```
MatteoVoges
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to reconstruct the list of classes for each target. Reclass provides this information in
rendered_target["classes"]already.This commit removes the loop which reconstructs the list and replaces it by assigning
rendered_target["classes"]to the target'sclassesfield.Side-note: the previous implementation also mangled the list, because Python implements
+=for lists as list concatenation, and (not so helpfully) treats strings as lists of characters when they appear in a context where a list is expected. To correctly construct the list of classes with the previous approach, the+=should be replaced with append:Docs and Tests