Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing initialization for applications and exports in reclass-rs backend #1160

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

simu
Copy link
Contributor

@simu simu commented Mar 18, 2024

This is a follow-up for #1059 and #1142. We forgot to include the fix in #1142 in #1059.

Proposed Changes

  • Fix incorrect default initializer for exports field of target
  • Set applications and exports in reclass-rs backend
  • Run Kubernetes compile tests with reclass-rs

Docs and Tests

  • Tests added
  • Updated documentation

simu added 3 commits March 18, 2024 19:32
…s-rs backend

We forgot to update kapicorp#1059 to also initialize the `applications` and
`exports` fields in the target dataclass in the reclass-rs backend. This
commit updates the reclass-rs backend to correctly initialize these
fields to match the fix in kapicorp#1142.
This should ensure that we catch any issues with the reclass-rs backend
for a relatively representative example of targets.
@ademariag ademariag merged commit 10b4e5e into kapicorp:master Mar 18, 2024
7 checks passed
@simu simu deleted the fix/reclass-rs-applications branch March 19, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants