refactor: renamed runner field per Peter's comments

Renamed ignoreJunitNoScenariosAssertion to failWhenNoScenariosFound. Refs: #2531
karatelabs · Mar 13, 2024 · d089d81 · d089d81
1 parent 74d94ca
commit d089d81
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 13 deletions.
diff --git a/karate-core/src/main/java/com/intuit/karate/Runner.java b/karate-core/src/main/java/com/intuit/karate/Runner.java
@@ -113,7 +113,7 @@ public static class Builder<T extends Builder> {
         boolean outputCucumberJson;
         boolean dryRun;
         boolean debugMode;
-        boolean ignoreJunitNoScenariosAssertion;
+        boolean failWhenNoScenariosFound;
         Map<String, String> systemProperties;
         Map<String, Object> callSingleCache;
         Map<String, ScenarioCall.Result> callOnceCache;
@@ -147,7 +147,7 @@ public synchronized Builder copy() {
             b.outputCucumberJson = outputCucumberJson;
             b.dryRun = dryRun;
             b.debugMode = debugMode;
-            b.ignoreJunitNoScenariosAssertion = ignoreJunitNoScenariosAssertion;
+            b.failWhenNoScenariosFound = failWhenNoScenariosFound;
             b.systemProperties = systemProperties;
             b.callSingleCache = callSingleCache;
             b.callOnceCache = callOnceCache;
@@ -439,10 +439,12 @@ public T debugMode(boolean value) {
             debugMode = value;
             return (T) this;
         }
-        public T ignoreJunitNoScenariosAssertion(boolean value) {
-            ignoreJunitNoScenariosAssertion = value;
+
+        public T failWhenNoScenariosFound(boolean value) {
+            failWhenNoScenariosFound = value;
             return (T) this;
         }
+
         public T callSingleCache(Map<String, Object> value) {
             callSingleCache = value;
             return (T) this;

diff --git a/karate-core/src/main/java/com/intuit/karate/Suite.java b/karate-core/src/main/java/com/intuit/karate/Suite.java
@@ -72,7 +72,7 @@ public class Suite implements Runnable {
     public final String tagSelector;
     public final boolean dryRun;
     public final boolean debugMode;
-    public final boolean ignoreJunitNoScenariosAssertion;
+    public final boolean failWhenNoScenariosFound;
     public final File workingDir;
     public final String buildDir;
     public final String reportDir;
@@ -130,7 +130,7 @@ public Suite(Runner.Builder rb) {
         if (rb.forTempUse) {
             dryRun = false;
             debugMode = false;
-            ignoreJunitNoScenariosAssertion = false;
+            failWhenNoScenariosFound = false;
             backupReportDir = false;
             outputHtmlReport = false;
             outputCucumberJson = false;
@@ -175,7 +175,7 @@ public Suite(Runner.Builder rb) {
             outputJunitXml = rb.outputJunitXml;
             dryRun = rb.dryRun;
             debugMode = rb.debugMode;
-            ignoreJunitNoScenariosAssertion = rb.ignoreJunitNoScenariosAssertion;
+            failWhenNoScenariosFound = rb.failWhenNoScenariosFound;
             classLoader = rb.classLoader;
             clientFactory = rb.clientFactory;
             env = rb.env;

diff --git a/karate-junit5/src/main/java/com/intuit/karate/junit5/Karate.java b/karate-junit5/src/main/java/com/intuit/karate/junit5/Karate.java
@@ -67,7 +67,7 @@ public Iterator<DynamicNode> iterator() {
             DynamicNode node = DynamicContainer.dynamicContainer(testName, featureNode);
             list.add(node);
         }
-        if (!suite.ignoreJunitNoScenariosAssertion && list.isEmpty()) {
+        if (suite.failWhenNoScenariosFound && list.isEmpty()) {
             Assertions.fail("no features or scenarios found: " + this);
         }
         return list.iterator();

diff --git a/karate-junit5/src/test/java/karate/NoFeatureNoScenarioTest.java b/karate-junit5/src/test/java/karate/NoFeatureNoScenarioTest.java
@@ -5,18 +5,18 @@
 class NoFeatureNoScenarioTest {
 
     @Karate.Test
-    Karate testValidTagWithIgnoreJunitNoScenarioAssertion() {
+    Karate testHasScenariosWithFailWhenNoScenariosFound() {
         return Karate.run("noFeatureNoScenario")
                      .tags("@smoke")
-                     .ignoreJunitNoScenariosAssertion(true)
+                     .failWhenNoScenariosFound(true)
                      .relativeTo(getClass());
     }
+
     @Karate.Test
-    Karate testInvalidTagWithIgnoreJunitNoScenarioAssertion() {
+    Karate testNoScenarios() {
         return Karate.run("noFeatureNoScenario")
                      .tags("@tagnotexist")
-                     .ignoreJunitNoScenariosAssertion(true)
+                     .failWhenNoScenariosFound(false)
                      .relativeTo(getClass());
     }
-
 }