2454: Preserve whitespace in node value when using karate.xmlPath #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codehackerr
commented
Feb 4, 2024
| @@ -111,6 +111,7 @@ public static Document toXmlDoc(String xml) { | |||
| public static Document toXmlDoc(String xml, boolean namespaceAware) { | |||
| DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance(); | |||
| factory.setNamespaceAware(namespaceAware); | |||
| factory.setIgnoringElementContentWhitespace(false); | |||
There was a problem hiding this comment.
false is the default setting. So nothing changes in the current document parsing behavior.
Added the above line to make the behavior explicit.
|
will request @bouncysteve to review |
bouncysteve
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the
developbranch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.