Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yosemite #16

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Yosemite #16

wants to merge 19 commits into from

Conversation

terrencetalbot
Copy link

this is NOT ready to be pulled. it is for comparison/discussion only between @terrencetalbot and @mikeabdullah

@terrencetalbot
Copy link
Author

OK @mikeabdullah, I think that’s all I want to do on this branch, if it ever gets used.

basically this branch:

  • converts code to ARC
  • puts all code into a proper .framework (Mac-only for now)
  • puts all tests under XCTest in a separate target
  • does away with any reference to SenTestingKit
  • does away with Jenkins and ocunit2junit stuff

which means that it still might need a way to collect statistics in a way that Xcode’s testing machinery can process, but this seems good enough for now

<key>CFBundleIdentifier</key>
<string>com.karelia.MockServerUnitTest</string>
<string>org.karelia.$(PRODUCT_NAME:rfc1034identifier)</string>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that’s weird. how did this become .org? That should likely be changed.

@terrencetalbot
Copy link
Author

This should not be merged with master but become 0.2.x when a bit further along. I’m leaving this PR open as a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant