warning: length comparison to zero --> server/src/event_bus.rs:140:20 | 140 | if v.len() == 0 { | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

length comparison to zero: server/src/event_bus.rs#L130

warning: length comparison to zero --> server/src/event_bus.rs:130:20 | 130 | if v.len() == 0 { | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

length comparison to zero: server/src/event_bus.rs#L93

warning: length comparison to zero --> server/src/event_bus.rs:93:20 | 93 | if v.len() == 0 { | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default

function `actix_log` is never used: server/src/logger.rs#L37

warning: function `actix_log` is never used --> server/src/logger.rs:37:8 | 37 | pub fn actix_log() -> middleware::Logger { | ^^^^^^^^^

type alias `Rx` is never used: server/src/event_bus.rs#L22

warning: type alias `Rx` is never used --> server/src/event_bus.rs:22:14 | 22 | pub type Rx = Receiver<Item>; | ^^

method `resolve_send` is never used: server/src/event_bus.rs#L40

warning: method `resolve_send` is never used --> server/src/event_bus.rs:40:18 | 31 | impl EventBus { | ------------- method in this implementation ... 40 | pub async fn resolve_send(&self, event: (ConcreteType, ConcreteValue)) -> anyhow::Result<()> { | ^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

variable does not need to be mutable: server/src/event_bus.rs#L167

warning: variable does not need to be mutable --> server/src/event_bus.rs:167:9 | 167 | let mut ultra_subs = 0u32; | ----^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

unused variable: `ty`: server/src/transports/udp.rs#L76

warning: unused variable: `ty` --> server/src/transports/udp.rs:76:21 | 76 | while let Some((ty, ev, (addr, id))) = event_bus.recv().await { | ^^ help: if this is intentional, prefix it with an underscore: `_ty` | = note: `#[warn(unused_variables)]` on by default

unused import: `event`: server/src/main.rs#L97

warning: unused import: `event` --> server/src/main.rs:97:13 | 97 | event, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default

redundant pattern matching, consider using `is_ok()`: roblib/src/gpio/backend/simple.rs#L102

warning: redundant pattern matching, consider using `is_ok()` --> roblib/src/gpio/backend/simple.rs:102:32 | 102 | if let Ok(_) = handle.last_value.fetch_update(SeqCst, SeqCst, |last| { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default help: try this | 102 ~ if handle.last_value.fetch_update(SeqCst, SeqCst, |last| { 103 + log::debug!("({last}) {value}"); 104 + if value != last { 105 + return Some(value); 106 + } 107 + None 108 ~ }).is_ok() { |

this boolean expression can be simplified: roblib/src/gpio/backend/simple.rs#L101

warning: this boolean expression can be simplified --> roblib/src/gpio/backend/simple.rs:101:37 | 101 | let value = !(l as u8 != 0); | ^^^^^^^^^^^^^^^ help: try: `l as u8 == 0` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool = note: `#[warn(clippy::nonminimal_bool)]` on by default

unused variable: `handler`: roblib/src/gpio/backend/typed.rs#L120

warning: unused variable: `handler` --> roblib/src/gpio/backend/typed.rs:120:9 | 120 | handler: impl FnMut(bool) -> Result<()> + Send + Sync + 'static, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_handler` | = note: `#[warn(unused_variables)]` on by default

Build - roland/x86_64-unknown-linux-gnu

Test - ubuntu-latest/nightly

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Test - ubuntu-latest/nightly

Build - base/x86_64-pc-windows-msvc

Build - base/aarch64-unknown-linux-gnu

Build - base/armv7-unknown-linux-gnueabihf

Build - roland/x86_64-pc-windows-msvc

Build - roland/aarch64-unknown-linux-gnu

Build - roland/armv7-unknown-linux-gnueabihf

Test - ubuntu-latest/stable

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Test - ubuntu-latest/stable

Artifacts

Produced during runtime

Name	Size
roblib-server-base-aarch64-unknown-linux-gnu Expired	2.43 MB
roblib-server-base-armv7-unknown-linux-gnueabihf Expired	2.08 MB
roblib-server-base-x86_64-pc-windows-msvc Expired	2.21 MB
roblib-server-base-x86_64-unknown-linux-gnu Expired	2.62 MB
roblib-server-roland-aarch64-unknown-linux-gnu Expired	2.78 MB
roblib-server-roland-armv7-unknown-linux-gnueabihf Expired	2.4 MB
roblib-server-roland-x86_64-pc-windows-msvc Expired	2.55 MB
roblib-server-roland-x86_64-unknown-linux-gnu Expired	2.99 MB

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

event bus refactor #112

Summary

event bus refactor #112

Jobs

Run details

ci.yml

Annotations

Artifacts