Add NodeJS FFI client library #7
beni69node.yml
on: pull_request
Matrix: build
Matrix: test-linux-aarch64-gnu-binding
Matrix: test-linux-arm-gnueabihf-binding
Matrix: test-linux-x64-gnu-binding
Matrix: test-linux-x64-musl-binding
Matrix: test-macOS-windows-binding
Publish
0s
Annotations
6 errors and 5 warnings
|
stable - x86_64-unknown-linux-gnu - node@18
Process completed with exit code 1.
|
|
stable - armv7-unknown-linux-gnueabihf - node@18
Dependencies lock file is not found in /home/runner/work/roblib-rs/roblib-rs. Supported file patterns: pnpm-lock.yaml
|
|
stable - aarch64-unknown-linux-gnu - node@18
Process completed with exit code 1.
|
|
stable - x86_64-unknown-linux-musl - node@18
Process completed with exit code 1.
|
|
stable - x86_64-apple-darwin - node@18
Dependencies lock file is not found in /Users/runner/work/roblib-rs/roblib-rs. Supported file patterns: pnpm-lock.yaml
|
|
stable - x86_64-pc-windows-msvc - node@18
Dependencies lock file is not found in D:\a\roblib-rs\roblib-rs. Supported file patterns: pnpm-lock.yaml
|
|
unsafe function's docs miss `# Safety` section:
node-ffi/src/lib.rs#L124
warning: unsafe function's docs miss `# Safety` section
--> node-ffi/src/lib.rs:124:5
|
124 | pub unsafe fn disconnect(&mut self) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
|
|
you should consider adding a `Default` implementation for `JsRobot`:
node-ffi/src/lib.rs#L99
warning: you should consider adding a `Default` implementation for `JsRobot`
--> node-ffi/src/lib.rs:99:5
|
99 | / pub fn new() -> Self {
100 | | panic!("Use Robot.connect instead of new Robot")
101 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
97 + impl Default for JsRobot {
98 + fn default() -> Self {
99 + Self::new()
100 + }
101 + }
|
|
|
unneeded `return` statement:
node-ffi/src/lib.rs#L92
warning: unneeded `return` statement
--> node-ffi/src/lib.rs:92:9
|
92 | return Ok(());
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
= help: remove `return`
|
|
unneeded `return` statement:
client/src/transports/tcp.rs#L336
warning: unneeded `return` statement
--> client/src/transports/tcp.rs:336:13
|
336 | return false;
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
= help: remove `return`
|
|
very complex type used. Consider factoring parts into `type` definitions:
client/src/transports/tcp.rs#L214
warning: very complex type used. Consider factoring parts into `type` definitions
--> client/src/transports/tcp.rs:214:14
|
214 | ) -> (
| ______________^
215 | | Self,
216 | | mpsc::UnboundedSender<(cmd::Concrete, Option<oneshot::Sender<D>>)>,
217 | | mpsc::UnboundedSender<(event::ConcreteType, Option<mpsc::UnboundedSender<D>>)>,
218 | | ) {
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|