Raise right exception on set_iso
#784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a couple of places in the `set_iso` method where an exception is not raised, so later on an invalid exception is raised, such as: ``` Hit 'NoneType' object has no attribute 'code' when plugging iso http://10.45.225.105/sno-devin-sno.iso to host with url https://devin03.mgmt.lab.eng.brq2.redhat.com/redfish/v1/Systems/System.Embedded.1 ``` That `NoneType` is referring to the code trying `result.code` when `result` has not been changed from the default because an exception had been risen. This patch fixes this error by raising the exception when it's encountered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of places in the
set_isomethod where an exception is not raised, so later on an invalid exception is raised, such as:That
NoneTypeis referring to the code tryingresult.codewhenresulthas not been changed from the default because an exception had been risen.This patch fixes this error by raising the exception when it's encountered.