Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token authentication 3rd party api #1115

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ketankartoza
Copy link
Contributor

This PR is for the issue #1097

@ketankartoza ketankartoza added the Documentation Improvements or additions to documentation label Oct 10, 2024
@ketankartoza ketankartoza self-assigned this Oct 10, 2024
@EliVolsch
Copy link

@ketankartoza Just want to check in and make sure you're aware this section needs to be changed as the URL is no longer the correct way to have a token generated

image

@ketankartoza
Copy link
Contributor Author

@EliVolsch, I am going to change the documentation for the token. I will open a PR for it today thanks!!

@ketankartoza ketankartoza force-pushed the Token-authentication-3rd-party-api branch from 52f25fa to c9b56da Compare October 11, 2024 10:58
Copy link
Collaborator

@amyburness amyburness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@tinashechiraya @EliVolsch let me know if you have any comments otherwise I will merge this asap

@tinashechiraya
Copy link
Contributor

@amyburness looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants