Upgrade to Swiper 11 #76
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using a very old version of [Swiper.js](https://swiperjs.com/). Moreover, our usage is partially broken - we'd like to have the "pagination" dots at the bottom (at least on small screens when all slides aren't visible), but they don't seem to be working. (Perhaps something is broken between our old version of Swiper and the react-id-swiper package we were using. - Stop using react-id-swiper. Swiper 11 comes with native react support. - Upgrade to Swiper React 11. Although the docs suggest Swiper React is deprecated and we should migrate to Swiper Element, I'm sticking with react for now because using Swiper Element with React and breakpoints involves more complication than I want to deal with. Let's keep it simple. Fixes #45
✅ Deploy Preview for confessit-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using a very old version of Swiper.js. Moreover, our usage is partially broken - we'd like to have the "pagination" dots at the bottom (at least on small screens when all slides aren't visible), but they don't seem to be working. (Perhaps something is broken between our old version of Swiper and the react-id-swiper package we were using.
Fixes #45