Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18Next Commit Hook #86

Merged
merged 1 commit into from
Jun 27, 2024
Merged

i18Next Commit Hook #86

merged 1 commit into from
Jun 27, 2024

Conversation

kas-catholic
Copy link
Owner

Add separate configs for English and other languages: English should populate default values, but other languages should not.

Scan in a pre-commit hook to make sure languages are set up correctly.

Language config file changes in this commit are evidence that the commit hook is working -- the changes are due to new config we have to sort keys.

Add separate configs for English and other languages: English should
populate default values, but other languages should not.

Scan in a pre-commit hook to make sure languages are set up correctly.

Language config file changes in this commit are evidence that the commit
hook is working -- the changes are due to new config we have to sort
keys.
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for confessit-web ready!

Name Link
🔨 Latest commit ac58ddc
🔍 Latest deploy log https://app.netlify.com/sites/confessit-web/deploys/667b8e0947e9ff000843183d
😎 Deploy Preview https://deploy-preview-86--confessit-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kas-catholic kas-catholic mentioned this pull request Jun 26, 2024
@JohnRDOrazio
Copy link
Collaborator

looks good to me!

@JohnRDOrazio
Copy link
Collaborator

another thing we could keep in mind when using the t function, is include a default value there too. It would in fact be better for the English to be populated with a default value rather than an empty value when a new key is added.

@kas-catholic kas-catholic merged commit e05c7dd into main Jun 27, 2024
5 checks passed
@kas-catholic kas-catholic deleted the mkasberg/i18next-scanner branch June 27, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants