Remove usage of unmaintained crate proc-macro-error. #41
Conversation
There was a problem hiding this comment.
This has a security advisory now? Ah, simply "unmaintained".
This is something I've been aware of for a while, however proc-macro2-diagnostics is not a drop-in replacement (see SergioBenitez/proc-macro2-diagnostics#8). This would be easier if rust-lang/rust#54140 would finally get resolved!
lib/src/autoimpl.rs
Outdated
| emit_error!(item, "expected struct"); | ||
| item.span().error("expected struct").emit_as_expr_tokens(); | ||
| Toks::new() |
There was a problem hiding this comment.
This is not a direct replacement. IIUC the new code here does nothing on stable. The old code would actually emit an error.
There was a problem hiding this comment.
Oh okey I was thinking that this was emitting looking at the other crates that made this migration. Sorry I'm not very familiar with details of proc-macro. Will try to drop-in replacement with the crate you mentioned.
There was a problem hiding this comment.
I get the feeling that other people may have made this mistake.
I started working on this including error-verification a while back, but gave up: https://github.com/kas-gui/impl-tools/commits/work/
Might as well just do the switch to proc-macro-error2 now though.
There was a problem hiding this comment.
Yeah I think a lot of proc-macro crate lack of error tests, I think mainly because they are boring/complex/.. to do, maybe with new IA tools it could be improved.
|
I see that https://crates.io/crates/proc-macro-error2 is now a thing. That would be the simplest replacement. |
|
I don't see any breaking changes and this dependency is not part of the public API, so we should be able to bump the version to 0.10.1. |
AurelienFT
force-pushed
the
remove_dependency_proc_macro_error
branch
from
13b1748 to
07ba7a9
Compare
|
MSRV fails because the new dep requires 1.61. Uh, I'll fix it in a new PR. |
|
Oopsie didn't saw CI results. |
Hi,
Thanks for this crate :)
Resolves https://rustsec.org/advisories/RUSTSEC-2024-0370.html
If that's possible to do a realase aftter merging this that would be awesome :)