[NOD-639] Make it possible to have address-less txs (#15)

* [NOD-639] Make Address and AddressID nullable.

* [NOD-639] Fix merge errors.

* [NOD-639] Make address_id nullable in the database schema.

* [NOD-639] Bring back the foreign key constraint over addresses.id.

database/migrations/000008_create_transaction_outputs_table.up.sql

@@ -6,7 +6,7 @@ CREATE TABLE `transaction_outputs`
     `value`          BIGINT UNSIGNED NOT NULL,
     `script_pub_key` BLOB            NOT NULL,
     `is_spent`       TINYINT         NOT NULL,
-    `address_id`     BIGINT UNSIGNED NOT NULL,
+    `address_id`     BIGINT UNSIGNED NULL,
     PRIMARY KEY (`id`),
     INDEX `idx_transaction_outputs_transaction_id` (`transaction_id`),
     CONSTRAINT `fk_transaction_outputs_transaction_id`

dbmodels/dbmodels.go

@@ -88,8 +88,8 @@ type TransactionOutput struct {
 	Value         uint64
 	ScriptPubKey  []byte
 	IsSpent       bool
-	AddressID     uint64
-	Address       Address
+	AddressID     *uint64
+	Address       *Address
 }
 
 // TransactionInput is the gorm model for the 'transaction_inputs' table

kasparovd/controllers/common.go

@@ -45,17 +45,21 @@ func convertTxDBModelToTxResponse(tx *dbmodels.Transaction) *apimodels.Transacti
 		txRes.Outputs[i] = &apimodels.TransactionOutputResponse{
 			Value:        txOut.Value,
 			ScriptPubKey: hex.EncodeToString(txOut.ScriptPubKey),
-			Address:      txOut.Address.Address,
 			Index:        txOut.Index,
 		}
+		if txOut.Address != nil {
+			txRes.Outputs[i].Address = txOut.Address.Address
+		}
 	}
 	for i, txIn := range tx.TransactionInputs {
 		txRes.Inputs[i] = &apimodels.TransactionInputResponse{
 			PreviousTransactionID:          txIn.PreviousTransactionOutput.Transaction.TransactionID,
 			PreviousTransactionOutputIndex: txIn.PreviousTransactionOutput.Index,
 			SignatureScript:                hex.EncodeToString(txIn.SignatureScript),
 			Sequence:                       txIn.Sequence,
-			Address:                        txIn.PreviousTransactionOutput.Address.Address,
+		}
+		if txIn.PreviousTransactionOutput.Address != nil {
+			txRes.Inputs[i].Address = txIn.PreviousTransactionOutput.Address.Address
 		}
 	}
 	return txRes

kasparovsyncd/sync.go

@@ -666,11 +666,9 @@ func insertAddress(dbTx *gorm.DB, scriptPubKey []byte) (*dbmodels.Address, error
 	if err != nil {
 		return nil, err
 	}
-
 	if addr == nil {
 		return nil, nil
 	}
-
 	hexAddress := addr.EncodeAddress()
 
 	var dbAddress dbmodels.Address
@@ -714,7 +712,7 @@ func insertTransactionOutput(dbTx *gorm.DB, dbTransaction *dbmodels.Transaction,
 			ScriptPubKey:  scriptPubKey,
 		}
 		if dbAddress != nil {
-			dbTransactionOutput.AddressID = dbAddress.ID
+			dbTransactionOutput.AddressID = &dbAddress.ID
 		}
 		dbResult := dbTx.Create(&dbTransactionOutput)
 		dbErrors := dbResult.GetErrors()