Raise when seed finds no files.
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case users pass a typo'ed name/path to `seed` we won't give them any indication of what's going on. Running a test fails silently. Now we raise when we can't find any files.
|
I'm not super happy with this implementation, all these details are pretty quangled together. Will try to sleep on it and see if I can come up with anything better. |
kaspth
commented
Jan 9, 2025
| end | ||
|
|
||
| private def load_from(path) | ||
| @loader = Oaken::Loader.new path |
There was a problem hiding this comment.
We don't need this @loader instance variable, since we're not using it anymore.
In case a user does `seed :accounts, :missing` we want to raise when we can't load from `:missing`. Previously, we'd proceed silently because `:accounts` found files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #95
In case users pass a typo'ed name/path to
seedwe won't give them any indication of what's going on.Running a test fails silently.
Now we raise when we can't find any files.