vfio: Extend the current VFIO test for GPU and other devices

[zvonkok]

The current VFIO test only works with a virtualized network device.
Extend the VFIO tests so that "any" device that is passed-through can be tested.

[zvonkok]

/test-vfio

[zvonkok]

/test-vfio

[zvonkok]

/test-vfio

[zvonkok]

/test-vfio

[zvonkok]

/test-vfio

[zvonkok]

/test-vfio

[zvonkok]

/test-vfio

[zvonkok]

/test

[zvonkok]

Added cold_plug_vfio test besides hot_plug_vfio test.

[zvonkok]

/retest-s390x

[BbolroC]

LGTM, thanks @zvonkok !

[zvonkok]

/test

[zvonkok]

@GabyCT PTAL Thanks!

[zvonkok]

/test-vfio

[zvonkok]

@jepio if the config variable is not available it will be not set, updating the sed command ...

[jepio]

@jepio if the config variable is not available it will be not set, updating the sed command ...

I don't think the sed expression is wrong, I think there is some logic error here:

        if [ "${VFIO_COLDPLUG}" != "bridge-port" ]; then

wouldn't you want this to check against no-port? Same for VFIO_HOTPLUG.

[zvonkok]

@jepio if you look at the config file generated there is no cold_plug_vfio variable to update.

10:59:50 hot_plug_vfio = "no-port"

The cold-plug test-case is started without the cold_plug_vfio=.... set.

[zvonkok]

Need to update the logic, a VFIO test can have both hot-plug and cold-plug set to the same value. One may want to test

hot_plug_vfio="root-port"

first and then

cold_plug_vfio="root-port"

[zvonkok]

So essentially we only need one VFIO_PORT setting since we test hot and cold plug in one run.

[zvonkok]

/test-vfio

[zvonkok]

/test-vfio

[jepio]

Looks like there's an actual bug in handling /dev/vfio/vfio in coldplug vfio mode

[zvonkok]

Yep, we need a "simple" runtime fix before merging this.

[zvonkok]

cold-plug vfio_mode=guest-kernel works as expected,
cold-plug vfio_mode=vfio misses the check for the VFIO control file.

[zvonkok]

During testing why it fails for cold_plug I found a bug in the hot_plug implementation. It depends in which order you supplied the vfio-control-device and the vfio-device-group.
1st vfio-control-device 2nd vfio-device-group -> works
2st vfio-device-group 2nd vfio-control-group -> breaks

[zvonkok]

/test-vfio