Added Solution for Assignment 2.1 #62
Conversation
| if process_command != "build": | ||
| raise Exception(process_command + ' is not a recognized process command') | ||
| return |
There was a problem hiding this comment.
Hmm, this "process_command" thing shouldn't be necessary, if there is only 1 allowed value for this.
| with open(os.path.join("build.json")) as json_file: | ||
| scripts = json.load(json_file) | ||
|
|
||
| for script in scripts: |
There was a problem hiding this comment.
Lets call these actions, or build-rules, or something.
I recommend creating a separate class for an Action, and maintaining a proper graph, because it will be useful in part3 of the problem.
| new_path = "" | ||
| for path_segment in path: | ||
| new_path += path_segment | ||
| self.execute_command(new_path, current_working_directory, process_command, new_script) |
There was a problem hiding this comment.
You need to detect circular dependencies and show appropriate error message.
| new_path += path_segment | ||
| self.execute_command(new_path, current_working_directory, process_command, new_script) | ||
| current_command = script['command'] | ||
| os.system(current_command) |
There was a problem hiding this comment.
This vaguely satisfied part1 of the problem statement, lets do part2 now.
| scripts = json.load(json_file) | ||
|
|
||
| for script in scripts: | ||
| if script['name'] == current_script: |
There was a problem hiding this comment.
What if I provide current_script = "algorithms/sort_bubble" ? The name in build.json will only be "sort_bubble", and you're not looking in the "algorithms" directory.
| os.chdir(previous_location) | ||
|
|
||
|
|
||
| def test_build_run(self): |
There was a problem hiding this comment.
Instead of creating new files in the current directory, use tempfile.TemporaryDirectory so that you can run multiple copies of the test in parallel.
|
|
||
| def test_build_run(self): | ||
| build_automation_tool_object = Build.BuildAutomationTool() | ||
| build_automation_tool_object.execute_command(os.getcwd(), os.getcwd(), 'build', 'run') |
There was a problem hiding this comment.
This API is suboptimal.
The fact that you need to maintain previous_working_directory is an implementation detail, that is an internal problem for the library, and should not affect the API.
Can you do something like:
BuildAutomationTool(root=".").execute("algorithms/sort_bubble")
Added solution for Build Automation Tool along with unit tests.