Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build automation tool. #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
.DS_Store
*.pyc
.vscode
120 changes: 120 additions & 0 deletions solutions/build-automation-tool/build.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
import enum
import json
import os
import subprocess
import sys


class Build(object):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks like this class represents a single build.json file, and so can be called "BuildConfig". The individual items inside that are called "BuildRule"s.
  • If you create a map<full_rule_name, BuildRule>, I don't think you need a BuildConfig class.

"""
The class builds the dependencies, checks for the existence of required
files and executes the build command for the specified name.
"""

class BuildSpecs(enum.Enum):
BUILD = 'build.json'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unexpected. The rest of the items are attributes of the BuildRule structure, but this one is the file name, and so inconsistent.

NAME = 'name'
DEPENDENCIES = 'dependencies'
FILES = 'files'
COMMAND = 'command'

def __init__(self, build_file=os.path.join(os.getcwd(), 'build.json')):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't really need a default value here, you can just provide this path from the main section.
Create the entire graph here, check for cyclic dependencies and stuff.

"""
:param build_file: Path of the build file.
:type build_file: str
"""

self.build_instructions = None
with open(build_file, 'r') as build_file:
self.build_instructions = json.load(build_file)

def _getBuildInstruction(self, name):
"""
Returns the build instruction available for name.

:param name: The name of the build instruction.
:type name: str
"""

for build_instruction in self.build_instructions:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of O(n) search, you can create a Map<name, config>

if build_instruction[self.BuildSpecs.NAME.value] == name:
return build_instruction
return None

def _buildDependencies(self, dependencies):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assumption: A depends on B & C, and both B & C depend on D.

  • Right now, you will build D twice. Can you avoid that?
  • Can you build B & C in parallel? Use subprocess.Popen, but you shouldn't need to use any multithreading.

"""
Builds the dependencies for the current build instruction.

:param dependencies: The dependecnies to build.
:type depenedecies: list
"""

for dependency in dependencies:
build_directory, name = os.path.split(dependency)
if build_directory:
current_directory = os.getcwd()
try:
os.chdir(build_directory)
build_dependency = Build(
os.path.join(os.getcwd(), self.BuildSpecs.BUILD.value))
build_dependency.build(name)
finally:
os.chdir(current_directory)
else:
build_dependency = Build(
os.path.join(os.getcwd(), self.BuildSpecs.BUILD.value))
build_dependency.build(name)

def _ensureFiles(self, files):
"""
Asserts if all the files are exists or not

:param files: Files to check for existence
:type files: list
"""

for file in files:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name "file" is not useful, since it isn't clear whether it is a file_name or file_handle or whatever else.

assert os.path.isfile(file)

def _executeCommand(self, command):
"""
Executes the command.

:param command: Command to execute
:type command: str
"""

completed_process = subprocess.run(
command,
shell=True,
check=True,
universal_newlines=True,
)
return completed_process.returncode

def build(self, name):
build_instruction = self._getBuildInstruction(name)
if build_instruction is None:
raise NameError(f'No build instruction for "{name}".')

self._buildDependencies(
build_instruction.get(self.BuildSpecs.DEPENDENCIES.value, []))
self._ensureFiles(
build_instruction.get(self.BuildSpecs.FILES.value, []))
self._executeCommand(
build_instruction.get(self.BuildSpecs.COMMAND.value, ""))


def main():
if len(sys.argv) <= 1:
sys.stdout.write("No build name given.")
sys.exit(0)
build = Build()
try:
build.build(name=sys.argv[1])
except NameError as e:
sys.stdout.write(str(e))


if __name__ == '__main__':
main()
106 changes: 106 additions & 0 deletions solutions/build-automation-tool/build_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
import contextlib
import json
import os
import tempfile
import textwrap
import unittest

from build import Build


@contextlib.contextmanager
def create_and_change_to_tmpdir(working_directory):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the caller need to provide working_directory? You can just calculate it here.

"""Creates and switches directory to the a new temporary directory."""

try:
tmpdir = tempfile.TemporaryDirectory()
os.chdir(tmpdir.name)
yield tmpdir
finally:
os.chdir(working_directory)


class BuildTest(unittest.TestCase):

def test_build(self):
with create_and_change_to_tmpdir(os.getcwd()):
build_file_1 = [{
"name": "clean",
"deps": ["algorithms/clean"],
"command": "rm -f test.o && rm -f test.exe"
}, {
"name": "test",
"files": ["test.cpp"],
"command": "g++ -std=c++11 -c test.cpp"
}, {
"name": "run",
"dependencies": [
"test", "algorithms/sort_bubble", "algorithms/sort_merge"
],
"command": "g++ algorithms/sort_bubble.o\
algorithms/sort_merge.o test.o -o test.exe && ./test.exe"
}]

build_file_2 = [{
"name": "clean",
"command": "rm -f *.o"
}, {
"name": "sort_bubble",
"files": ["sort_bubble.cpp"],
"command": "g++ -c sort_bubble.cpp"
}, {
"name": "sort_merge",
"files": ["sort_merge.cpp"],
"command": "g++ -c sort_merge.cpp"
}]

with open('build.json', 'w') as build:
json.dump(build_file_1, build)

with open('test.cpp', 'w') as test:
test.write(textwrap.dedent("""\
#include <bits/stdc++.h>
using namespace std;

int main() {
return 0;
}"""))

os.mkdir('algorithms')

with open('algorithms/build.json', 'w') as build:
json.dump(build_file_2, build)

with open('algorithms/sort_bubble.cpp', 'w') as sort_bubble:
sort_bubble.write(textwrap.dedent("""
#include <bits/stdc++.h>
using namespace std;

int bubble() {
return 0;
}"""))

with open('algorithms/sort_merge.cpp', 'w') as sort_merge:
sort_merge.write(textwrap.dedent("""
#include <bits/stdc++.h>
using namespace std;

int merge() {
return 0;
}"""))

build = Build(os.path.join(os.getcwd(), 'build.json'))

build.build("test")
assert os.path.exists("test.o")

build.build("run")
assert os.path.exists("test.exe")

build.build("clean")
assert not os.path.exists("test.o")
assert not os.path.exists("test.exe")


if __name__ == '__main__':
unittest.main()