Skip to content

Commit

Permalink
let’s try building the image in the workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
Luke Brody committed Aug 13, 2024
1 parent d77eeef commit 67369a9
Show file tree
Hide file tree
Showing 2 changed files with 53 additions and 20 deletions.
59 changes: 45 additions & 14 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,51 @@
name: check
on: [push]
env:
REGISTRY: ghcr.io
IMAGE_NAME: ${{ github.repository }}/e2e
jobs:
# lint:
# runs-on: ubuntu-22.04
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-node@v4
# with:
# node-version: 20
# - run: npm ci
# working-directory: react
# - run: npx eslint .
# working-directory: react
e2e:
lint:
runs-on: ubuntu-22.04
# needs: lint # don't want to waste e2e runs
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/e2e-test
- uses: actions/setup-node@v4
with:
node-version: 20
- run: npm ci
working-directory: react
- run: npx eslint .
working-directory: react
build-and-push-image:
runs-on: ubuntu-22.04
permissions:
contents: read
packages: write
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Log in to the Container registry
uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Extract metadata (tags, labels) for Docker
id: meta
uses: docker/metadata-action@98669ae865ea3cffbcbaa878cf57c20bbf1c6c38
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}

- name: Build and push Docker image
uses: docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc
with:
context: .
file: react/test/Dockerfile
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
e2e:
runs-on: ubuntu-22.04
needs: build-and-push-image
container:
image: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
14 changes: 8 additions & 6 deletions .github/actions/e2e-test/Dockerfile → react/test/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
FROM ubuntu:22.04
FROM node:20

# RUN apt-get -y update
# RUN apt-get -y install python3-pip
# RUN apt-get -y install libgdal-dev
RUN apt-get -y update
RUN apt-get -y install python3-pip
RUN apt-get -y install libgdal-dev

RUN find /home -maxdepth 3 -type d
RUN pip3 install --break-system-packages -r $GITHUB_WORKSPACE/requirements.txt
WORKDIR /urbanstats
COPY ./requirements.txt ./
RUN pip3 install --break-system-packages -r requirements.txt

RUN apt-get -y install chromium
RUN apt-get -y install xvfb
Expand All @@ -20,4 +21,5 @@ RUN apt-get -y install libc6:i386
RUN apt-get -y install libx11-6:i386
RUN apt-get -y install fluxbox

CMD ./$GITHUB_WORKSPACE/test-ci.sh
COPY ./ ./
CMD ./test-ci.sh

0 comments on commit 67369a9

Please sign in to comment.