-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add histograms for population density #300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kavigupta
commented
Aug 18, 2024
•
edited
Loading
edited
- seems like the domestic histograms aren't being generated for american states / urban centers
- add drawing of histograms
- add cumulative histograms
- add population scaling to histograms
- add toggle button
- make toggle button reliant on a setting
- per square mile
- fix the rounding
- add colors
- add hoverable values
- add tests for how the histograms display
- add tests for hoverable values (might be hard)
- add test for png download
- add tests for nans
- add segments for kinds of place (maybe not doing this)
- fix rendering of toggle button
- fix font size
- bar chart toggle
- fix bar chart spacing
- why does it say "name"
- legend
- gracefully handle nans
- no negative yaxes
- fix y axis
- make elements go away for screenshot
- wrong order???
- chart download
…ic into add-histograms
kavigupta
added a commit
that referenced
this pull request
Sep 1, 2024
Split off from #300 for testing purposes. This should have 0 pixel-level effects on anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.