counts_by_article_type as a protobuf #921
Conversation
| @@ -407,6 +409,7 @@ export async function loadPageDescriptor(newDescriptor: PageDescriptor, settings | |||
| data: await data, | |||
| renderedStatname: newDescriptor.statname, | |||
| universe: statUniverse, | |||
| counts: await counts(), | |||
There was a problem hiding this comment.
This and the await counts() above it might fire off two calls.... either confirm the browser is smart enough to cache & combine them, or prefer one const countsResult = await counts() above. (Naming should probably be const counts = await getCounts()
There was a problem hiding this comment.
Wait it's cached in the ts though right?
There was a problem hiding this comment.
Oh missed this. In this case prefer making loadArticle async using getCountsByArticleType() within that function. This reduces complexity by moving code that deals with article type counts closer to where we need to care about it.
There was a problem hiding this comment.
For this line you can add a simple await getCountsByArticleType() rather than needing a separate variable.
There was a problem hiding this comment.
StatisticPanel needs this to compute the set of universes to display, I've added a comment to this effect
There was a problem hiding this comment.
fixed the redundancy of counts as a variable
Resolves #830