Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kcl fmt action #33

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix kcl fmt action #33

merged 2 commits into from
Jul 10, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 10, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

  1. override deprecated api getActionUpdateThread
  2. update kcl fmt comman kcl kcl-fmt -> kcl fmt
  3. use EnvironmentUtil.getValue to get environment variable. ref: https://stackoverflow.com/questions/26320583/system-getenv-only-works-properly-when-debugging-intellij-plugin

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 562adff into main Jul 10, 2024
5 checks passed
@Peefy Peefy deleted the 0.8.19 branch July 10, 2024 03:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin action not activated (grayed out)
2 participants