Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default value with k8s x-order extension #123

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #121

fix: default value with k8s x-order extension

Copy link

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11661786286

Details

  • 2 of 94 (2.13%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.7%) to 66.056%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/swagger/generator/model.go 2 94 2.13%
Files with Coverage Reduction New Missed Lines %
pkg/swagger/generator/model.go 1 60.03%
Totals Coverage Status
Change from base Build 11659997566: -1.7%
Covered Lines: 2306
Relevant Lines: 3491

💛 - Coveralls

1 similar comment
@coveralls
Copy link
Collaborator

coveralls commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11661786286

Details

  • 2 of 94 (2.13%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.7%) to 66.056%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/swagger/generator/model.go 2 94 2.13%
Files with Coverage Reduction New Missed Lines %
pkg/swagger/generator/model.go 1 60.03%
Totals Coverage Status
Change from base Build 11659997566: -1.7%
Covered Lines: 2306
Relevant Lines: 3491

💛 - Coveralls

@Peefy Peefy merged commit b80f946 into main Nov 4, 2024
7 of 9 checks passed
@Peefy Peefy deleted the fix-default-value-with-x-order-generation branch November 4, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Wrong schema attribute default values with value and x-order fields
3 participants