add workflow script: sync k8s models #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amy <[email protected]>
Peefy
reviewed
Nov 13, 2023
main.py
Outdated
| pass | ||
|
|
||
| if __name__ == '__main__': | ||
| main() |
There was a problem hiding this comment.
Remove the swagger.json file.
main.py
Outdated
| @@ -0,0 +1,338 @@ | |||
| # Copyright 2016 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Why construct a new file here. Ref: https://github.com/kcl-lang/kcl-openapi/blob/main/scripts/preprocess/main.py
| run: go build | ||
| - name: sync k8s models | ||
| run: | | ||
| tags=("1.28" "1.29" "1.30" "1.31" "1.32" "1.33") |
There was a problem hiding this comment.
Do we need to process and synchronize other versions of the k8s modules here?
.github/workflows/sync_models.yml
Outdated
| rm -f ${spec_path} | ||
| wget https://raw.githubusercontent.com/kubernetes/kubernetes/release-${tag}/api/openapi-spec/swagger.json -O ${spec_path} | ||
| python ./scripts/preprocess/main.py ${spec_path} --omit-status --rename=io.k8s=k8s | ||
| ./kcl-openapi generate model -f processed-${spec_path} |
There was a problem hiding this comment.
I noticed that the title of the relevant Jira transaction states that the model still needs to be uploaded. How do we upload the model here, or is this PR only used to complete the testing function of model generation.
Signed-off-by: amy <[email protected]>
amyXia1994
force-pushed
the
workflow/sync-k8s-models
branch
from
3c3a669
to
a08897d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add workflow script: sync k8s models by manually trigger the github workflow