feat: enhance config attr type checking

kcl-lang · Sep 12, 2023 · f10be0f · f10be0f
1 parent 40d1dcc
commit f10be0f
Show file tree

Hide file tree

Showing 9 changed files with 90 additions and 0 deletions.
diff --git a/kclvm/sema/src/resolver/config.rs b/kclvm/sema/src/resolver/config.rs
@@ -478,6 +478,13 @@ impl<'ctx> Resolver<'ctx> {
                                     doc: None,
                                 },
                             );
+                            attrs.insert(
+                                string_lit.value.clone(),
+                                Attr {
+                                    ty: val_ty.clone(),
+                                    range: key.get_span_pos(),
+                                },
+                            );
                         }
                         key_types.push(key_ty);
                         val_types.push(val_ty.clone());

diff --git a/test/grammar/types/config/config_ty_0/main.k b/test/grammar/types/config/config_ty_0/main.k
@@ -0,0 +1,14 @@
+config: {str:} = {
+    "key" = [
+        {
+            key = "value"
+        }
+    ]
+    "values": [
+        "foo"
+        "bar"
+    ]
+}
+
+if "foo" in config.values:
+    a = 1
diff --git a/test/grammar/types/config/config_ty_0/stdout.golden b/test/grammar/types/config/config_ty_0/stdout.golden
@@ -0,0 +1,7 @@
+config:
+  key:
+  - key: value
+  values:
+  - foo
+  - bar
+a: 1
diff --git a/test/grammar/types/config/config_ty_1/main.k b/test/grammar/types/config/config_ty_1/main.k
@@ -0,0 +1,14 @@
+config: {str:} = {
+    key = [
+        {
+            key = "value"
+        }
+    ]
+    values: [
+        "foo"
+        "bar"
+    ]
+}
+
+if "foo" in config.values:
+    a = 1
diff --git a/test/grammar/types/config/config_ty_1/stdout.golden b/test/grammar/types/config/config_ty_1/stdout.golden
@@ -0,0 +1,7 @@
+config:
+  key:
+  - key: value
+  values:
+  - foo
+  - bar
+a: 1
diff --git a/test/grammar/types/config/config_ty_2/main.k b/test/grammar/types/config/config_ty_2/main.k
@@ -0,0 +1,12 @@
+config: {str:} = {
+    "key" = [
+        {
+            key = "value"
+        }
+    ]
+    "values" = [
+        "foo"
+        "bar"
+    ]
+}
+values: [str] = config.values
diff --git a/test/grammar/types/config/config_ty_2/stdout.golden b/test/grammar/types/config/config_ty_2/stdout.golden
@@ -0,0 +1,9 @@
+config:
+  key:
+  - key: value
+  values:
+  - foo
+  - bar
+values:
+- foo
+- bar
diff --git a/test/grammar/types/config/config_ty_3/main.k b/test/grammar/types/config/config_ty_3/main.k
@@ -0,0 +1,12 @@
+config: {str:} = {
+    "map" = [
+        {
+            key = "value"
+        }
+    ]
+    "values" = [
+        "foo"
+        "bar"
+    ]
+}
+$map: [{str:str}] = config.map
diff --git a/test/grammar/types/config/config_ty_3/stdout.golden b/test/grammar/types/config/config_ty_3/stdout.golden
@@ -0,0 +1,8 @@
+config:
+  map:
+  - key: value
+  values:
+  - foo
+  - bar
+map:
+- key: value