Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ${pkg_name:KCL_MOD} in entry #1644

Closed
wants to merge 3 commits into from
Closed

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Sep 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy
Copy link
Contributor

Peefy commented Sep 12, 2024

Konfig completion test CI failed.

kclvm/driver/src/lib.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/compile.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/compile.rs Outdated Show resolved Hide resolved
kclvm/parser/src/entry.rs Outdated Show resolved Hide resolved
@He1pa He1pa force-pushed the fix_pkg_mod branch 2 times, most recently from d832ed9 to ecf5618 Compare September 12, 2024 13:53
Signed-off-by: he1pa <[email protected]>
@Peefy
Copy link
Contributor

Peefy commented Sep 13, 2024

dup with #1646

@Peefy Peefy closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants