Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix parser cache dead lock #1706

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 21, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

parse_file() will write in cache, cause dead lock

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 9114c24 into kcl-lang:main Oct 21, 2024
12 of 13 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11438886105

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 23 of 25 (92.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 70.508%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/lib.rs 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 3 64.97%
kclvm/tools/src/LSP/src/state.rs 7 83.86%
kclvm/tools/src/LSP/src/dispatcher.rs 7 65.71%
Totals Coverage Status
Change from base Build 11434991515: -0.01%
Covered Lines: 51725
Relevant Lines: 73360

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants