Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] feat: lsp file watcher #1738

Closed
wants to merge 1 commit into from
Closed

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

for event in self.fs_event_watcher._receiver.try_iter() {
if let Ok(e) = event {
match e.kind {
notify::EventKind::Modify(modify_kind) => match modify_kind {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the if let pattern to prevent the cargo clippy warnings.

@coveralls
Copy link
Collaborator

coveralls commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11696321805

Details

  • 18 of 51 (35.29%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 70.58%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/state.rs 18 51 35.29%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/compile.rs 1 80.17%
Totals Coverage Status
Change from base Build 11677384978: 0.01%
Covered Lines: 52035
Relevant Lines: 73725

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants