Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace "__main__" by package name when parse import statments in entry. #660

Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix: replace "__main__" by package name when parse import statments in entry. #660

merged 1 commit into from
Aug 15, 2023

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Aug 15, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm/parser/src/lib.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Aug 15, 2023
@zong-zhe zong-zhe added this to the v0.6.0 Release milestone Aug 15, 2023
@zong-zhe zong-zhe requested a review from Peefy August 15, 2023 03:45
@zong-zhe zong-zhe self-assigned this Aug 15, 2023
@zong-zhe zong-zhe changed the title feat: replace "__main__" by package name when parse import statments … fix: replace "__main__" by package name when parse import statments in entry. Aug 15, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 69b962b into kcl-lang:main Aug 15, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants