Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lsp db to store compile state. #665

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 17, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

add lsp db to store compile state. query and analysis from db when handle request

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added the lsp label Aug 17, 2023
@He1pa He1pa self-assigned this Aug 17, 2023
@coveralls
Copy link
Collaborator

coveralls commented Aug 17, 2023

Pull Request Test Coverage Report for Build 5901128417

  • 1 of 123 (0.81%) changed or added relevant lines in 7 files are covered.
  • 26 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-18.4%) to 69.569%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/scope.rs 0 1 0.0%
kclvm/tools/src/LSP/src/db.rs 0 1 0.0%
kclvm/tools/src/LSP/src/analysis.rs 0 3 0.0%
kclvm/tools/src/LSP/src/request.rs 0 29 0.0%
kclvm/tools/src/LSP/src/notification.rs 0 31 0.0%
kclvm/tools/src/LSP/src/state.rs 0 57 0.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 26 58.06%
Totals Coverage Status
Change from base Build 5874151134: -18.4%
Covered Lines: 32804
Relevant Lines: 47153

💛 - Coveralls

kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/state.rs Show resolved Hide resolved
kclvm/tools/src/LSP/src/state.rs Outdated Show resolved Hide resolved
@He1pa He1pa force-pushed the lsp_db branch 3 times, most recently from 2403926 to 6b406ae Compare August 18, 2023 08:48
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 6a3f3dc into kcl-lang:main Aug 18, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants