Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require attr check for nested list and config values. #672

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 18, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #669

feat: enhance require attribute check for list and config values.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/value/val_schema.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/optional_attr/fail_13/main.k
  • test/grammar/schema/optional_attr/fail_14/main.k

@Peefy Peefy added bug Something isn't working runtime Issues or PRs related to kcl runtime including value and value opertions labels Aug 18, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Aug 18, 2023
@Peefy Peefy self-assigned this Aug 18, 2023
@Peefy Peefy merged commit f332d3f into kcl-lang:main Aug 18, 2023
10 checks passed
@Peefy Peefy deleted the enhance-require-attr-check branch August 18, 2023 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested schema instantiation does not error on missing attribute
1 participant