fix(namespaces): unify namespace settings and improve naming readability #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Standardized namespace configurations across all workloads for consistency. - Resolved issue where some workloads did not allow setting a namespace. - Updated the naming template to include hyphens (`-`) for better readability. These changes enhance deployment consistency, prevent namespace misconfigurations, and improve clarity in resource names. Signed-off-by: Emin Aktas <[email protected]>
|
Thank you. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix #24
2. What is the scope of this PR (e.g. component or file name):
Affects the namespace settings for workloads and updates naming templates to improve readability.
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
This PR unifies the namespace configurations for all workloads to ensure consistency and addresses the issue where some workloads did not allow namespaces to be set. Additionally, it updates the naming template by adding hyphens (-) for better readability.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
No breaking changes. Namespace settings will now be consistent across workloads, and names will be more readable, but these changes should not disrupt existing functionality.
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: