Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change env to map in the front-end model #7

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 26, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • examples/appops/nginx-example/base/base.k
  • models/kube/frontend/container/container.k
  • models/kube/frontend/container/env/env.k

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy force-pushed the change-env-map-in-the-front-end-module branch 2 times, most recently from ac73b0d to f1365cf Compare March 26, 2024 11:53
@Peefy Peefy force-pushed the change-env-map-in-the-front-end-module branch from f1365cf to ba2c394 Compare March 26, 2024 11:59
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 4193546 into main Mar 26, 2024
5 checks passed
@Peefy Peefy deleted the change-env-map-in-the-front-end-module branch March 26, 2024 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants