Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata into oci manifest when 'kpm push' #205

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixed #201

2. What is the scope of this PR (e.g. component or file name):

pkg/oci/oci.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

When the kpm push is executed, some of the data required by AH is filled into the annotation field of the OCI manifest conf.

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Oct 23, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy October 23, 2023 07:20
@zong-zhe zong-zhe self-assigned this Oct 23, 2023
pkg/oci/oci.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6609991077

  • 3 of 25 (12.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 36.983%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/client.go 0 1 0.0%
pkg/cmd/cmd_push.go 0 1 0.0%
pkg/package/package.go 0 6 0.0%
pkg/oci/oci.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/cmd_push.go 1 10.08%
pkg/oci/oci.go 1 6.93%
Totals Coverage Status
Change from base Build 6477129858: -0.1%
Covered Lines: 1233
Relevant Lines: 3334

💛 - Coveralls

pkg/oci/oci.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 0de32be into kcl-lang:main Oct 23, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: v0.7.0 Release Done
3 participants