Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api to 'GetFullSchemaTypeMappingWithFilters' #220

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixes kcl-lang/kcl#891

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Nov 29, 2023
@zong-zhe zong-zhe self-assigned this Nov 29, 2023
@coveralls
Copy link

coveralls commented Nov 30, 2023

Pull Request Test Coverage Report for Build 7044100908

  • 39 of 53 (73.58%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 36.519%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/api/kpm_pkg.go 39 53 73.58%
Totals Coverage Status
Change from base Build 6953371559: 0.5%
Covered Lines: 1307
Relevant Lines: 3579

💛 - Coveralls

@zong-zhe zong-zhe changed the title [WIP] feat: add api to 'GetFullSchemaTypeMappingWithFilters' feat: add api to 'GetFullSchemaTypeMappingWithFilters' Nov 30, 2023
@zong-zhe zong-zhe marked this pull request as ready for review November 30, 2023 07:39
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit b60b9ef into kcl-lang:main Nov 30, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

[Enhancement] integrate with KCL tools and KPM APIs Enhancement: kpm add command displaying optimization
3 participants