Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run remote repo in kpm run #251

Merged

Conversation

AkashKumar7902
Copy link
Contributor

@AkashKumar7902 AkashKumar7902 commented Jan 24, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: #184

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@AkashKumar7902
Copy link
Contributor Author

@zong-zhe please take a look !

pkg/client/client.go Outdated Show resolved Hide resolved
Signed-off-by: Akash Kumar <[email protected]>
@coveralls
Copy link

coveralls commented Feb 16, 2024

Pull Request Test Coverage Report for Build 7946120425

Details

  • -13 of 47 (72.34%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 41.179%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/runner/entry.go 2 5 40.0%
pkg/client/client.go 18 22 81.82%
pkg/cmd/cmd_run.go 0 6 0.0%
Totals Coverage Status
Change from base Build 7759303822: 0.5%
Covered Lines: 1634
Relevant Lines: 3968

💛 - Coveralls

Signed-off-by: Akash Kumar <[email protected]>
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution 👏

@zong-zhe zong-zhe merged commit f67db1b into kcl-lang:main Feb 18, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants