Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE, TEST cover ]Registry port support config. #424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Aug 1, 2024

make cover is running on local but failing on PR

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@liangyuanpeng liangyuanpeng changed the title [DO NOT MERGE, TESTING]Registry port support config. [DO NOT MERGE, TEST cover ]Registry port support config. Aug 1, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10199838721

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.261%

Totals Coverage Status
Change from base Build 10198962112: 0.0%
Covered Lines: 3121
Relevant Lines: 7752

💛 - Coveralls

@liangyuanpeng
Copy link
Contributor Author

Seems like have some flake tests here, also reproduce on local.

downloading 'kcl-lang/argo-cd-order:0.2.0' from 'ghcr.io/kcl-lang/argo-cd-order:0.2.0'
2024/08/01 14:14:32 Error getting tags: pinging container registry ghcr.io: Get "https://ghcr.io/v2/": dial tcp 140.82.113.34:443: i/o timeout
FAIL	kcl-lang.io/kpm/pkg/mvs	31.870s

@liangyuanpeng
Copy link
Contributor Author

The second problem:

err: dependency 'flask-demo-kcl-manifests' not found in '/home/runner/.kcl/kpm/flask-demo-kcl-manifests_ade147b'

    client_test.go:626: 
        	Error Trace:	/home/runner/work/kpm/kpm/pkg/client/client_test.go:626
        	Error:      	Not equal: 
        	            	expected: *reporter.KpmEvent(&reporter.KpmEvent{errType:61, msg:"", err:(*errors.errorString)(0xc0004bbdf0)})
        	            	actual  : <nil>(<nil>)
        	Test:       	TestResolveMetadataInJsonStr
    client_test.go:642: 
        	Error Trace:	/home/runner/work/kpm/kpm/pkg/client/client_test.go:642
        	Error:      	Not equal: 
        	            	expected: ""
        	            	actual  : "{\"packages\":{\"flask_demo_kcl_manifests\":{\"name\":\"flask_demo_kcl_manifests\",\"manifest_path\":\"/home/runner/.kcl/kpm/flask-demo-kcl-manifests_ade147b\"}}}"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-
        	            	+{"packages":{"flask_demo_kcl_manifests":{"name":"flask_demo_kcl_manifests","manifest_path":"/home/runner/.kcl/kpm/flask-demo-kcl-manifests_ade147b"}}}
        	Test:       	TestResolveMetadataInJsonStr
    client_test.go:651: 
        	Error Trace:	/home/runner/work/kpm/kpm/pkg/client/client_test.go:651
        	Error:      	Not equal: 
        	            	expected: *reporter.KpmEvent(&reporter.KpmEvent{errType:23, msg:"could not load 'kcl.mod' in '/home/runner/work/kpm/kpm/pkg/client/test_data/resolve_metadata/vendor/flask-demo-kcl-manifests_ade147b'", err:(*fs.PathError)(0xc00071a840)})
        	            	actual  : <nil>(<nil>)
        	Test:       	TestResolveMetadataInJsonStr
    client_test.go:665: 
        	Error Trace:	/home/runner/work/kpm/kpm/pkg/client/client_test.go:665
        	Error:      	Not equal: 
        	            	expected: ""
        	            	actual  : "{\"packages\":{\"flask_demo_kcl_manifests\":{\"name\":\"flask_demo_kcl_manifests\",\"manifest_path\":\"/home/runner/work/kpm/kpm/pkg/client/test_data/resolve_metadata/vendor/flask-demo-kcl-manifests_ade147b\"}}}"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-
        	            	+{"packages":{"flask_demo_kcl_manifests":{"name":"flask_demo_kcl_manifests","manifest_path":"/home/runner/work/kpm/kpm/pkg/client/test_data/resolve_metadata/vendor/flask-demo-kcl-manifests_ade147b"}}}
        	Test:       	TestResolveMetadataInJsonStr
--- FAIL: TestResolveMetadataInJsonStr (0.00s)

Let me check it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
2 participants